Opened 4 years ago

Last modified 3 years ago

#2401 closed change

Integrate CSS property rule handling in Firefox — at Version 5

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #2396, #3499, #3813
Blocking: #2398 Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338602/
https://codereview.adblockplus.org/29338638/

Description

Background

Once all the necessary mechanisms are in place, we still need code to make sure the content script for CSS property rules is applied.

What to change

Update adblockplusui dependency in order to use the latest messageResponder.js version. Add code to listen to new documents being created, inject the content script into any pages having CSS property rules associated with them.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Blocked By 3499 added; 2399 removed
  • Tester set to Unknown

comment:2 Changed 3 years ago by trev

  • Blocked By 2400 removed

comment:3 Changed 3 years ago by trev

  • Blocked By 3813 added

comment:4 Changed 3 years ago by trev

  • Owner set to trev

comment:5 Changed 3 years ago by trev

  • Review URL(s) modified (diff)

Put a tiny change to the content script under review, it won't work correctly in Firefox otherwise. Will create a separate review for the main code shortly.

Note: See TracTickets for help on using tickets.