Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2414 closed defect (fixed)

[adblockplus.org Anwiki to CMS migration] merge_children logic in conversion script is sub-optimal

Reported by: kzar Assignee: trev
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: trev Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

Description

Background

There appears to be a flaw in the merge_children function of the website conversion script. Translation strings are sometimes broken up by non-translatable <a> tags even though they shouldn't be.

For example look at the "Firefox Privacy Policy" link at the bottom of the pages/privacy.html page.

What to change

Debug and fix the merge_children function so that whitelisted tags such as <a> are always included in a translation string where possible. Avoid translation strings being broken up by them.

Change History (4)

comment:1 Changed 5 years ago by trev

  • Owner set to trev

comment:2 Changed 5 years ago by trev

  • Ready set

comment:3 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 5 years ago by Ross

  • Verified working set

Fixed.

Tested by:
Checking link tags on beta.adblockplus.org and checking output after running conversion script.

cms / r44
adblockplus-website-converter / 105208883c

Note: See TracTickets for help on using tickets.