Opened 6 years ago

Last modified 19 months ago

#242 closed defect

chrome: hiding filters do not work — at Version 10

Reported by: mapx Assignee:
Priority: P3 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords: externaldependency, circumvention
Cc: saroyanm, sebastian, fanboy, arthur, scuturic, Lain_13, mjethani, hfiguiere, hayato, kochi, SMed79, BrentM, weissmar Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mapx)


Adblock Plus

How to reproduce

go to

Observed behaviour

the filter (easylist),,,,

is not working

Expected behaviour

the SimpleAcceptableTextAds class is not hidden
in Firefox the class is hidden

Ad visible due to "display: block !important;"

see also

Change History (10)

comment:1 Changed 6 years ago by mapx

another example:
go to
choose a match (flash, not unibet where you must have an account), a window opens with the top bar:
"Update your OnlineHD for Chrome in order to watch this video online"

in firefox the bar is hidden, but not in chrome

comment:2 Changed 6 years ago by mapx

  • Description modified (diff)

comment:3 Changed 6 years ago by mapx

  • Description modified (diff)

comment:4 Changed 6 years ago by trev

This isn't something we can fix as long as we are using regular <style> tags for element hiding. We should check whether chrome.tabs.insertCSS does things better by now and inserts a real user stylesheet. But even if it does we'll still have to file a Chromium issue - InjectDetails should allow specifying a frame ID rather than "all frames" only.

Last edited 6 years ago by trev (previous) (diff)

comment:5 Changed 6 years ago by trev

  • Cc trev added

comment:6 Changed 6 years ago by philll

  • Keywords externaldependency added
  • Priority changed from P2 to P3
  • Ready set

comment:7 Changed 6 years ago by trev

Just checked, chrome.tabs.insertCSS will inject a proper user stylesheet. However, !important keyword is ignored for user stylesheets ( The issue has been incorrectly resolved, it seems that we need to file a new one.

I couldn't find an existing issue on frameId support in chrome.tabs.insertCSS, we need to file that one as well.

comment:8 Changed 6 years ago by mapx

the chromium devs are not very open to such approach:

comment:9 Changed 6 years ago by trev

That issue is irrelevant here - it's explicitly about user stylesheet files that users put into their profiles manually, not about extensions which stay supported.

comment:10 Changed 6 years ago by mapx

  • Description modified (diff)
Note: See TracTickets for help on using tickets.