Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2433 closed change (fixed)

Add promotional image to the Adblock Browser beta launch landing page

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: annlee@… Blocked By: #2213
Blocking: #2436 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6357168420814848/
http://codereview.adblockplus.org/6097796419551232/

Description (last modified by saroyanm)

Background

In #2213 we have created a landing page for Adblock Browser beta launch, but we still need promotional image for that.

What to change

Add promotional image from the attachment to the page Adblock Browser Beta landing page:
<meta property="og:image" content="">

Attachments (1)

adblockbrowser_beta_promo.png (48.7 KB) - added by saroyanm 5 years ago.
Adblock Browser Beta promo image

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:2 Changed 5 years ago by saroyanm

  • Blocked By 2213 added

comment:3 Changed 5 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:4 Changed 5 years ago by saroyanm

  • Status changed from new to reviewing

comment:5 Changed 5 years ago by saroyanm

  • Blocking 2436 added

comment:6 follow-up: Changed 5 years ago by greiner

Is this image meant to be english-only or do we intend to translate it or let others translate it into more languages?

comment:7 in reply to: ↑ 6 Changed 5 years ago by saroyanm

  • Cc annlee@… added

Replying to greiner:

Is this image meant to be english-only or do we intend to translate it or let others translate it into more languages?

Well I don't think that make sense to put that much effort in translation, we will need to have separate image for each translation and I consider that translatable title and description should be enough.
But definitely make sense to update ticket with new image.

Changed 5 years ago by saroyanm

Adblock Browser Beta promo image

comment:8 follow-up: Changed 5 years ago by Ross

The image is present in the directory and the meta tag appears in the page correctly. The only thing I noticed is that it is hardcoded to http://adblockplus.org instead of a relative URL like everything else (which is 10.10.10.10 in the VM).

It's not really possible to test if social networks pull the correct image, as they can't see the VM used for testing.

Tested with:

IE8.0.6001Windows XP
IE11.0.9600Windows 8.1
Chrome42.0.2311.135Windows 8.1
Opera29.0.1795.47Windows 8.1
Firefox37.0.2Windows 8.1
Chrome42.0.3211.111Android 4.2.2

comment:9 in reply to: ↑ 8 Changed 5 years ago by saroyanm

Replying to Ross:

The only thing I noticed is that it is hardcoded to http://adblockplus.org instead of a relative URL like everything else (which is 10.10.10.10 in the VM).

I think it's Okey, I can't find official documentation where it mentions that og:image can be relative, but people usually using absolute url for og:image I think it's because of some social networks crawlers, that want the og:image URL be absolute. So I think it's better to keep it absolute.

It's not really possible to test if social networks pull the correct image, as they can't see the VM used for testing.

Should be Okey.

comment:10 Changed 4 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 4 years ago by saroyanm

  • Sensitive unset
Note: See TracTickets for help on using tickets.