Opened 5 years ago

Closed 5 years ago

#2443 closed change (fixed)

ensure_dependencies.py should honour SKIP_DEPENDENCY_UPDATES env variable

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian, fhd, trev Blocked By:
Blocking: #2445 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5652679430766592/

Description (last modified by kzar)

Background

The ensure_dependencies.py script is included in a lot of our repositories, it is usually set to automatically refresh all dependencies every time build scripts are run. In some situations it would be useful to manually disable this, so that dependencies are not refreshed automatically.

What to change

Add a check for the SKIP_DEPENDENCY_UPDATES environment variable to the ensure_dependencies.py script in the buildtools repository. If present the script should simply display warnings instead of checking out revisions or cloning repositories.

Change History (8)

comment:1 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 5 years ago by fhd

  • Cc fhd added

comment:3 Changed 5 years ago by trev

  • Cc trev added

comment:4 Changed 5 years ago by kzar

  • Description modified (diff)

comment:5 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 5 years ago by matze

  • Blocking 2445 added

comment:7 Changed 5 years ago by kzar

  • Description modified (diff)
  • Summary changed from ensure_dependencies.py should honour SKIP_ENSURE_DEPENDENCIES env variable to ensure_dependencies.py should honour SKIP_DEPENDENCY_UPDATES env variable

comment:8 Changed 5 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.