Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2457 closed defect (fixed)

[cms] Translatable attributes are escaped twice

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/6596081882234880/

Description

How to reproduce

Put the following code on a Markdown page:

{{string Some <a href="{{string-link http://example.com/?foo&bar}}">link</a>}}

Observed behaviour

The following code is being generated:

Some <a href="http://example.com/?foo&amp;amp;bar">link</a>

Note that the ampersand is being escaped twice.

Expected behaviour

The following code should be generated:

Some <a href="http://example.com/?foo&amp;bar">link</a>

Change History (3)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by Ross

  • Verified working set

Fixed.

Tested by:
Adding provided example to a CMS page and checking the output.

cms / r42

Note: See TracTickets for help on using tickets.