Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2460 closed change (fixed)

[cms] Support <span> tags inside translatable strings

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5484402612109312/

Description

Background

On https://beta.adblockplus.org/en/customize-facebook the text "Customize Facebook with Adblock Plus" is currently broken up into multiple translatable strings because "Facebook" is inside a <span> tag.

What to change

Allow <span> inside translatable strings.

Change History (3)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by Ross

  • Verified working set

Fixed.

Tested by:
Adding an example string with <span> tags to a CMS page and checking the output.

Sidenote:
https://beta.adblockplus.org/en/customize-facebook does not seem to exist any more. Is that correct?

cms / r42

Note: See TracTickets for help on using tickets.