Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2461 closed change (fixed)

Move our custom strings out of strings.xml.in

Reported by: fhd Assignee: Mailkov
Priority: P3 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015081632
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://bitbucket.org/adblockplus/adblockbrowser/pull-request/1

Description

Background

We're currently storing a bunch of strings in strings.xml.in. We're just supposed to reference strings from android_strings.dtd there, however.

What to change

Move all of our custom strings from strings.xml.in to android_strings.dtd and only refer to them by key in strings.xml.in - the same way all the upstream strings do it.

Change History (10)

comment:1 Changed 5 years ago by fhd

  • Sensitive unset

comment:2 Changed 5 years ago by Mailkov

I would like to work on this... Can you assign it to me?

comment:3 follow-up: Changed 5 years ago by fhd

  • Owner set to Mailkov

Sure, done!

Could you do a pull request on BitBucket with this when you're done? We don't have a GitHub mirror for this one.

comment:4 in reply to: ↑ 3 Changed 5 years ago by Mailkov

Replying to fhd:

Sure, done!

Could you do a pull request on BitBucket with this when you're done? We don't have a GitHub mirror for this one.

Sure, there is no problem.

comment:5 Changed 4 years ago by Mailkov

I want advice you that I completed this issue but I have some problems to make the pull request.

comment:7 Changed 4 years ago by fhd

  • Status changed from new to reviewing

comment:8 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)

comment:9 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Note: See TracTickets for help on using tickets.