Changes between Initial Version and Version 1 of Ticket #2464


Ignore:
Timestamp:
05/06/2015 04:56:49 PM (5 years ago)
Author:
fhd
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2464

    • Property Summary changed from Hard code language in the top site links to Localise adblockplus.org and acceptableads.org link
  • Ticket #2464 – Description

    initial v1  
    11=== Background === 
    2 We're currently linking to `acceptableads.org` and `adblockplus.org` from the top sites. These sites, however, do a redirect based on the user's language, so they end up on `adblockplus.org/en` for example - a different site. Consequently, this shows up as a separate top site. 
     2We're currently linking to `acceptableads.org` and `adblockplus.org` in our default bookmarks. These sites, however, do a redirect based on the user's language, so they end up on `adblockplus.org/en` for example - a different site. Consequently, this shows up as a separate top site. 
    33 
    44=== What to change === 
    5 Change the top sites links from: 
     5Change the default bookmark links from: 
    66 
    77`adblockplus.org` to `adblockplus.org/en` 
     
    1111`acceptableads.org` to `acceptableads.org/en` 
    1212 
    13 Saving the default bookmarks is not necessary, but we can safely do it if that makes the code change simpler. 
     13For simplicity's sake, the link should be translatable for now.