Opened 5 years ago

Last modified 4 years ago

#2464 closed change

Add language part to the top sites links — at Version 6

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5092578215067648/

Description (last modified by fhd)

Background

We're currently linking to acceptableads.org and adblockplus.org in our top sites. These sites, however, do a redirect based on the user's language, so they end up on adblockplus.org/en/ for example - a different site. Consequently, this shows up as a separate top site.

What to change

Change the top sites links from:

adblockplus.org to adblockplus.org/en/

and:

acceptableads.org to acceptableads.org/en/

The link is stored in a translation file anyway, so we can have a different link for each language. That's not brilliant, but good enough for now.

Change History (6)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from Hard code language in the top site links to Localise adblockplus.org and acceptableads.org link

comment:2 Changed 5 years ago by fhd

  • Owner set to fhd

comment:3 Changed 5 years ago by fhd

  • Description modified (diff)

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from Localise adblockplus.org and acceptableads.org link to Add language part to the top sites links

comment:5 Changed 5 years ago by fhd

  • Description modified (diff)

comment:6 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.