Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#2469 closed change (fixed)

Add missing platforms to Trac

Reported by: greiner Assignee: philll
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: matze, trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5709986743189504

Description (last modified by philll)

Background

Currently, we can choose from the following platforms when creating an issue:

  • Unknown
  • Android
  • Chrome
  • Firefox/Firefox Mobile
  • Internet Explorer
  • Kitt
  • Maxthon
  • Maxthon for Android
  • Opera
  • Safari

We do, however, also officially support SeaMonkey, Thunderbird and Yandex.Browser (see Adblock Plus system requirements). This means that for instance SeaMonkey-specific issues such as #2447 cannot be marked as such.

Furthermore by having a combined entry for Firefox and Firefox Mobile we also cannot mark an issue as Firefox Mobile-specific which means that we also can't query for those.

What to change

Replace the possible values for the Platform field with the following:

  • Unknown
  • Android
  • Chrome
  • Firefox
  • Firefox Mobile
  • Internet Explorer
  • Kitt
  • Maxthon
  • Maxthon for Android
  • Opera
  • Safari
  • SeaMonkey
  • Thunderbird
  • Yandex.Browser

Issues that are already assigned to "Firefox/Firefox Mobile" should use "Firefox" as the Platform field value instead.

Change History (7)

comment:1 Changed 5 years ago by philll

The reason why we didn't do this so far is that it's wrong in most cases to only mark one platform, if more are affected. However, that already holds true with the current selection. The background there is that Trac doesn't support multi selects for custom fields out of the box, a feature which could be added one of those plugins:
https://trac-hacks.org/wiki/TracMultiSelectBoxPlugin
https://trac-hacks.org/wiki/MultiSelectFieldPlugin
As we are already using a hell lot of plugins, we refrained from adding more for security and maintenance reasons.

Version 0, edited 5 years ago by philll (next)

comment:2 Changed 5 years ago by greiner

There's always someone who has to investigate the issue and who can then correct the Platform value if necessary. That has always been the case. If an issue affects multiple platforms then there's no need to set the Platform field at the moment, but that's a different discussion.

The main issue is that it's very much inconsistent. "Firefox" and "Firefox Mobile" are grouped together whereas "Chrome" and "Opera" are separate even though they're just as - if not even more - similar. And as mentioned in the description some platforms are missing entirely. Listing each platform separately appears to be the most consistent approach to resolve these issues.

comment:3 Changed 5 years ago by trev

  • Cc matze trev added
  • Priority changed from Unknown to P4
  • Ready set

comment:4 Changed 5 years ago by philll

  • Cc philll removed
  • Description modified (diff)
  • Owner set to philll
  • Review URL(s) modified (diff)

comment:5 Changed 5 years ago by philll

  • Status changed from new to reviewing

comment:6 Changed 5 years ago by philll

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.