Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2474 closed defect (fixed)

Sync settings show up on tablets

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5094895349923840/

Description (last modified by fhd)

Environment

Adblock Browser for Android revision 989a6e356d4a on a Nexus 9 running Android 5.0.2. This issue only appears on tablets.

How to reproduce

  1. Open the settings (from the hamburger menu)
  2. Touch Customize (if it isn't selected already)

Observed behaviour

There's an item called Sync on the right side.

Expected behaviour

There shouldn't be an item called Sync (see #2417).

Change History (8)

comment:1 Changed 4 years ago by fhd

  • Description modified (diff)
  • Summary changed from Remove Sync from the tablet preferences to Sync settings show up on tablets
  • Type changed from change to defect

Apparently our upstream merge (#2352) has added a new Customize preferences menu on tablets, where Sync has to be removed too.

comment:2 Changed 4 years ago by fhd

  • Description modified (diff)

comment:3 Changed 4 years ago by fhd

  • Owner set to fhd

comment:4 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 4 years ago by fhd

  • Sensitive unset

comment:8 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Note: See TracTickets for help on using tickets.