Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#2477 closed defect (fixed)

Adblocking settings are missing on tablets

Reported by: fhd Assignee: fhd
Priority: P1 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4883633424826368/

Description

Environment

Adblock Browser for Android revision 989a6e356d4a on a Nexus 9 running Android 5.0.2. This issue only appears on tablets.

How to reproduce

  1. Open the settings (from the hamburger menu)

Observed behaviour

There is no item called Adblocking on the left side.

Expected behaviour

There should be an item called Adblocking leading to the adblocking settings activity on the left side.

Change History (7)

comment:1 Changed 5 years ago by fhd

Pretty sure this is a regression introduced by our upstream merge (#2352).

comment:2 Changed 5 years ago by fhd

  • Owner set to fhd

comment:3 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by fhd

  • Sensitive unset

comment:7 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Note: See TracTickets for help on using tickets.