Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#2478 closed change (fixed)

Disable crash reporting

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: #2490 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5127392146227200/

Description

Background

Our upstream merge (#2352) has apparently added a crash reporter, that'll send this data to Mozilla servers. We don't want this for now.

What to change

  1. Ensure the crash reporter is not activated automatically (currently it's opt-out)
  2. Hide or remove the Crash Reporter setting under Settings->Adblock Browser->Data choices.

Change History (9)

comment:1 Changed 5 years ago by rjeschke

  • Owner set to rjeschke

comment:2 Changed 5 years ago by rjeschke

The solution is a build configuration switch:

Add

ac_add_options --disable-crashreporter

to mozconfig and it's gone.

comment:3 Changed 5 years ago by rjeschke

We can probably add a line to the README, pointing to this important change. Will put up a review for this.

Next step is: creating a follow up issue to investigate if there's another way of disabling this.

comment:4 Changed 5 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by rjeschke

  • Blocking 2490 added

comment:6 Changed 5 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by fhd

  • Sensitive unset

comment:9 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Note: See TracTickets for help on using tickets.