Opened 6 years ago

Closed 2 years ago

#248 closed change (rejected)

Show disabled filters in issue reports

Reported by: arthur Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: famlam, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by trev)

Background

A user has the possibility to disable some filters in a filter subscription. When an issue report is submitted later, Adblock Plus will only send the number of disabled filters to the server but not the actual filters that were disabled. This is a concern for filter list authors because they cannot see whether the reported issue is caused by the disabled filters. Forum topic: https://adblockplus.org/forum/viewtopic.php?f=11&t=11585

What to change

famlam suggests the following solutions (preferred solutions first):

  1. Don't allow filing reports if matching filters are disabled (reasoning: if I remove a random file from the FF setup, it'll break too, so why would lists work fine if you disable them partially).
  2. Show the disabled filters in gray, just like when I disable filters and look at the resources list in FF.
  3. In the filters tab, below the matching filters, show the disabled filters that would have matched.
  4. Instead of showing "yes, 8 filter(s)", show all matching filters that are disabled.

Change History (4)

comment:1 Changed 6 years ago by philll

  • Cc famlam added

comment:2 Changed 5 years ago by trev

  • Cc trev added
  • Description modified (diff)
  • Platform set to Firefox/Firefox Mobile
  • Priority changed from Unknown to P4

From what I can tell, the problematic scenario here is a rather uncommon one:

  • The user needs to have disabled some filters (already uncommon).
  • These filters (out of thousands) would normally have an effect on the page that the report was created for.
  • Disabling these filters is what caused the issue the user is complaining about.

Still, if we decide to fix it then the first suggestion seems reasonable. We can test whether any of the disabled filters would have matched (by going through the list of blockable items for blocking rules and by using document.querySelector() on all frames for element hiding rules). If we find such rules, we should show a page requesting the user to enable them and reload the page before submitting the report. We already do that if we detect a custom exception rule for the page for example.

comment:3 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:4 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.