Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#2483 closed change (fixed)

Give Adblock Browser its own app ID

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Kirill Blocked By:
Blocking: #2520 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6238034718621696/

Description (last modified by fhd)

Background

Adblock Browser needs its own app ID - it currently has the same one as Firefox for Android.

What to change

Change the app ID of Adblock Browser to 55aba3ac-94d3-41a8-9e25-5c21fe874539.

Change History (17)

comment:1 Changed 5 years ago by fhd

We're currently using fennec2 as our app ID, looks like we'll have to change this one way or another.

If we change the app ID, ABP won't work anymore - it's hard coding fennec2 in a few places. If we do change the app ID, we can back out the commit that disabled compatibility checking.

The alternative would be to monkey patch downloader.js, which may be a bit less effort.

comment:2 Changed 5 years ago by fhd

I think the cleanest approach would be to change the app ID indeed. We need to make some changes to ABP upstream, and we can't really do that before announcing the browser - that's the downside. However, we could commit a patch for that and apply it at build time for now. Once we release, we can just merge this patch upstream.

comment:3 Changed 5 years ago by fhd

  • Owner set to fhd

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from Download requests are indistinguishable from ABP for Firefox requests to Give Adblock Browser a unique app ID
  • Type changed from defect to change

Yeah, we definitely want to change the app ID - turning this into a change.

comment:5 Changed 5 years ago by fhd

  • Blocked By 2509, 2510 added
  • Description modified (diff)

comment:6 Changed 5 years ago by fhd

  • Summary changed from Give Adblock Browser a unique app ID to Give Adblock Browser its own app ID

comment:7 Changed 5 years ago by fhd

  • Blocked By 2509 removed

comment:8 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from reviewing to reopened

comment:10 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:11 Changed 5 years ago by fhd

  • Description modified (diff)
Version 0, edited 5 years ago by fhd (next)

comment:12 Changed 5 years ago by fhd

  • Blocking 2520 added

comment:13 Changed 5 years ago by Kirill

  • Cc Kirill added

comment:14 Changed 5 years ago by fhd

  • Blocked By 2510 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 5 years ago by fhd

  • Sensitive unset

comment:17 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Note: See TracTickets for help on using tickets.