Opened 5 years ago

Last modified 5 years ago

#2483 closed change

Give Adblock Browser a unique app ID — at Version 5

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-
Module: Adblock-Browser-for-Android Keywords:
Cc: Kirill Blocked By: #2509, #2510
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by fhd)


Adblock Browser needs its own app ID - it currently has the same one as Firefox for Android.

What to change

  1. Change the app ID of Adblock Browser to 55aba3ac-94d3-41a8-9e25-5c21fe874539.
  2. Revert our changes to the compatibility checking code in the browser - it'll work fine once we have our own app ID.

Change History (5)

comment:1 Changed 5 years ago by fhd

We're currently using fennec2 as our app ID, looks like we'll have to change this one way or another.

If we change the app ID, ABP won't work anymore - it's hard coding fennec2 in a few places. If we do change the app ID, we can back out the commit that disabled compatibility checking.

The alternative would be to monkey patch downloader.js, which may be a bit less effort.

comment:2 Changed 5 years ago by fhd

I think the cleanest approach would be to change the app ID indeed. We need to make some changes to ABP upstream, and we can't really do that before announcing the browser - that's the downside. However, we could commit a patch for that and apply it at build time for now. Once we release, we can just merge this patch upstream.

comment:3 Changed 5 years ago by fhd

  • Owner set to fhd

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from Download requests are indistinguishable from ABP for Firefox requests to Give Adblock Browser a unique app ID
  • Type changed from defect to change

Yeah, we definitely want to change the app ID - turning this into a change.

comment:5 Changed 5 years ago by fhd

  • Blocked By 2509, 2510 added
  • Description modified (diff)
Note: See TracTickets for help on using tickets.