Opened 5 years ago

Closed 2 years ago

#2490 closed change (fixed)

Investigate another way to disable the crash reporter

Reported by: rjeschke Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: fhd Blocked By: #2478
Blocking: #3767, #4566, #4567 Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29342994/

Description (last modified by diegocarloslima)

As we currently do not want to have Firefox' crash reporter enabled, we disable it completely with a build configuration switch.

Investigate if there is another clean way to disable the crash reporter without having the developer add ac_add_options --disable-crashreporter in mozconfig file.

Hints for Testers

The crash reporter can be verified as disabled by checking if MOZ_CRASHREPORTER = false in AppConstants.java after building the project. It should always be false, no matter the mozconfig configuration:
1) For a mozconfig file with ac_add_options --disable-crashreporter config option
2) For a mozconfig file with ac_add_options --enable-crashreporter config option
3) For a mozconfig file with none of the above config options

Change History (15)

comment:1 Changed 5 years ago by fhd

  • Sensitive unset

comment:2 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

comment:3 Changed 4 years ago by diegocarloslima

  • Owner set to diegocarloslima
  • Tester set to Unknown

comment:4 Changed 4 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by diegocarloslima

  • Blocking 3767 added

comment:6 Changed 3 years ago by diegocarloslima

  • Blocking 4566 added

comment:7 Changed 3 years ago by diegocarloslima

  • Blocking 4567 added

comment:8 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 2490 - Investigate another way to disable the crash reporter

comment:9 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 2 years ago by scheer

  • Cc fhd added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

What was the change here exactly if any at all? Could you please add some description of the change and hints for testers?

Thanks

comment:11 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:12 Changed 2 years ago by diegocarloslima

The change was made in configure.in file to make sure that MOZ_CRASHREPORTER will always be set to false, independently of the configuration in mozconfig file. I have updated the description with more info

comment:13 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:14 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:15 Changed 2 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set
  • MOZ_CRASHREPORTER = false in AppConstants.java.

adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.