Opened 5 years ago

Closed 2 years ago

#2520 closed change (fixed)

Enable extension compatibility checking again

Reported by: fhd Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #2483
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29344661/

Description (last modified by diegocarloslima)

Background

We've disabled extension compatibility checking in Adblock Browser, since it used the same app ID as Firefox, but a different (lower) version. Once #2483 is done, it will have its own app ID, and we can enable compatibility checking again.

What to change

Revert commit e278fae063ee.

Hints for Testers

This can be tested together with #4765 . With compatibility check enabled, it means that it will check if the ABP plugin is compatible with the ABB MOZ_APP_ID, which is55aba3ac-94d3-41a8-9e25-5c21fe874539 (ABP defines the compatible IDs here) and with the ABB app version, which is 1.1.1 (ABP defines the compatible versions here. So basically this issue can be verified by the fact that the ABP plugin is working after re-enabling compatibility check.

Change History (14)

comment:1 Changed 5 years ago by fhd

  • Sensitive unset

comment:2 Changed 4 years ago by Mailkov

I would like to work on this... Can you assign it to me?

comment:4 Changed 4 years ago by rjeschke

  • Owner set to Mailkov

comment:5 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

comment:6 Changed 4 years ago by Mailkov

Please! can you unassign me?

After the discussion with rjeschke ...
I think I'm underestimated so there are no conditions for work!

comment:7 Changed 3 years ago by diegocarloslima

  • Owner changed from Mailkov to diegocarloslima
  • Tester set to Unknown

comment:8 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 2520 - Enable extension compatibility checking again

comment:10 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 2 years ago by scheer

  • Tester changed from Unknown to Scheer

Could we add some hints for testers here please?

Thanks

comment:12 Changed 2 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:13 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:14 Changed 2 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set
  • The ABP plugin works after re-enabling the compatibility check.

adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.