Opened 5 years ago

Closed 5 years ago

#2528 closed change (fixed)

Don't parse CSS selectors that have no comma

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4759827771293696

Description

Background

In order to use Shadow DOM, we convert the CSS selectors, injecting the ::content pseudo-element. Therefore we have to parse selectors including commas. However, most selectors in EasList (and other filter lists) don't contain a comma, and could be converted more efficiently, by simply prepanding ::content without parsing the selector.

What to change

Implement a shortcut simply prepanding ::content rather than parsing the selector if it doesn't include any comma.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.