Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2530 closed defect (fixed)

Selecting Korean language causes all pages to 404

Reported by: Ross Assignee: trev
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: kzar, saroyanm, trev Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/6504702795579392/

Description (last modified by trev)

Environment

Chrome 42.0.2311.135 (but any browser)

How to reproduce

  1. Visit https://beta.adblockplus.org
  2. Select Korean (한국어) from the language drop-down.
  3. Observe the page 404's.
  4. Visit another page in Korean like https://beta.adblockplus.org/ko/firefox
  5. Observe all pages seem to now 404.

Observed behaviour

Korean is visible in the list yet selecting it produces 404 error.

Expected behaviour

Any language that is visible in the list shouldn't cause pages to 404.

Change History (6)

comment:1 Changed 5 years ago by Ross

This does not seem to occur in any other language and /locales/ does have a /ko/ directory full of translation files.

comment:2 Changed 5 years ago by kzar

  • Cc trev added

Can reproduce but doesn't happen when I run the website locally? Problem with the server set up?

comment:3 Changed 5 years ago by trev

  • Component changed from Unknown to Sitescripts
  • Description modified (diff)
  • Owner set to trev
  • Priority changed from Unknown to P2
  • Ready set

It's only happening when generating static pages - we don't generate all pages, only the ones that have been translated to at least 30% (see #2340). It seems that we didn't quite implement this correctly.

comment:4 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by Ross

  • Verified working set

Fixed.

Tested by:
Checking output after generating static files.

cms / r44
web.adblockplus.org / r72

Note: See TracTickets for help on using tickets.