Opened on 05/15/2015 at 01:12:15 PM
Closed on 05/15/2015 at 01:57:05 PM
Last modified on 05/18/2015 at 03:47:10 PM
#2530 closed defect (fixed)
Selecting Korean language causes all pages to 404
Reported by: | Ross | Assignee: | trev |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kzar, saroyanm, trev | Blocked By: | |
Blocking: | #2035 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | yes | |
Review URL(s): |
Description (last modified by trev)
Environment
Chrome 42.0.2311.135 (but any browser)
How to reproduce
- Visit https://beta.adblockplus.org
- Select Korean (한국어) from the language drop-down.
- Observe the page 404's.
- Visit another page in Korean like https://beta.adblockplus.org/ko/firefox
- Observe all pages seem to now 404.
Observed behaviour
Korean is visible in the list yet selecting it produces 404 error.
Expected behaviour
Any language that is visible in the list shouldn't cause pages to 404.
Attachments (0)
Change History (6)
comment:1 Changed on 05/15/2015 at 01:13:10 PM by Ross
comment:2 Changed on 05/15/2015 at 01:15:42 PM by kzar
- Cc trev added
Can reproduce but doesn't happen when I run the website locally? Problem with the server set up?
comment:3 Changed on 05/15/2015 at 01:43:05 PM by trev
- Component changed from Unknown to Sitescripts
- Description modified (diff)
- Owner set to trev
- Priority changed from Unknown to P2
- Ready set
It's only happening when generating static pages - we don't generate all pages, only the ones that have been translated to at least 30% (see #2340). It seems that we didn't quite implement this correctly.
comment:4 Changed on 05/15/2015 at 01:45:07 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/15/2015 at 01:57:05 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/18/2015 at 03:47:10 PM by Ross
- Verified working set
Fixed.
Tested by:
Checking output after generating static files.
cms / r44
web.adblockplus.org / r72
This does not seem to occur in any other language and /locales/ does have a /ko/ directory full of translation files.