Opened 4 years ago

Closed 3 weeks ago

#2539 closed change (rejected)

Move VCS abstraction part of ensure_dependencies into a separate module

Reported by: trev Assignee:
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4995669794226176/

Description

Background

We have some VCS abstraction code in ensure_dependencies.py for Mercurial and Git. It would be nice to reuse that elsewhere, e.g. in packager.getBuildNum(). However, ensure_dependencies.py shouldn't be imported from since it isn't really a module.

What to change

Turn ensure_dependencies.py into a real module and move the VCS abstraction into a separate module. Make sure that the ensure_dependencies.py script generated in the repository combines all the dependent modules however and can be used stand-alone.

Change History (5)

comment:1 Changed 4 years ago by sebastian

  • Component changed from Unknown to Build-and-Release-Tools
  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by trev

  • Status changed from reviewing to reopened
  • Tester set to Unknown

comment:4 Changed 2 years ago by trev

  • Owner trev deleted

Unassigning, I am not working on this.

comment:5 Changed 3 weeks ago by sebastian

  • Resolution set to rejected
  • Status changed from reopened to closed

Rejecting this issue now as buildtools is in maintenance mode and will eventually be discontinued.

Note: See TracTickets for help on using tickets.