Opened 5 years ago

Closed 5 years ago

#2569 closed change (fixed)

Leave errors in chrome.webRequest.onBeforeRequest listener unhandled

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5108699911684096

Description (last modified by sebastian)

Background

With #179 we wrapped the chrome.webRequest.onBeforeRequest listener into a try..catch block, considering the behavior introduced with https://crbug.com/349139, cancelling the request when an error occurs in that listener. However, this decision was reverted 15 days later with CL 212693002, and was only visible in the Chrome 35 Canary builds for that short time, but didn't make it into any release version.

What to change

Remove the try..catch block introduced with #179 as work around for https://crbug.com/349139.

Change History (4)

comment:1 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.