Opened 5 years ago

Closed 4 years ago

#2596 closed change (fixed)

[Move core logic into adblockpluscore repository] Change adblockplus dependency to adblockpluscore in libadblockplus

Reported by: kzar Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd Blocked By: #2594, #3613
Blocking: #2593 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340602/

Description (last modified by sergz)

Background

Once we have successfully moved the core logic from adblockplus to adblockpluscore #2594 we need to replace the adblockplus dependency with adblockpluscore in the libadblockplus repository.

What to change

Replace the adblockplus dependency with adblockpluscore in the libadblockplus repository and ensure the required core code is still included.

Use adblockpluscore at the newer revision hg:82c88024773b, (currently corresponding revision is adblockpluscore:hg:4a2dceec386a==adblockplus:hg:813682c7161e, see #3337).

The changes imported by this are:

Ticket Summary Component
#3952 Fix whitespaces in Python code for compliance with PEP-8 Unknown
#3889 Dispatch subscription downloading event instead of downloadStatus when transfer begins Core
#3879 CSS property filters ignore third-party stylesheets in Chrome but not in Firefox Core
#3873 Replace more occurrences of __proto__ with Object.create(null) Core
#3862 Implement FilterNotifier.on(action, callback) and FilterNotifier.off(action, callback) Core
#3836 Don't set DownloadableSubscription.upgradeRequired in Synchronizer Core
#3660 Remove locale dependency from subscription classes Core
#3659 Remove locale dependency from filter classes Core
#3654 CSS property filter prefix and suffix improperly applied Platform
#3618 Generate JSDoc documentation for adblockpluscore Core
#3612 Fix `typeMask` parameter type in functions description Core
#3538 Filter listener tests fail for CSS property rules Adblock-Plus-for-Firefox
#2598 [Move core logic into adblockpluscore repository] Add readme to adblockpluscore repository Core
#2401 Integrate CSS property rule handling in Firefox Adblock-Plus-for-Firefox


changes without issues:

74987c2906acNoissue - Removed redundant URL compatibility logicSebastian Noack

Change History (9)

comment:1 Changed 5 years ago by kzar

  • Blocked By 2594 added

comment:2 Changed 4 years ago by fhd

  • Component changed from Unknown to Libadblockplus
  • Ready set
  • Tester set to Unknown

comment:3 Changed 4 years ago by sergz

  • Blocked By 3613 added

comment:4 Changed 4 years ago by fhd

  • Owner set to sergz

Assigning to sergz, since he's actually looking into that.

comment:5 Changed 4 years ago by fhd

  • Priority changed from Unknown to P2

comment:6 Changed 4 years ago by sergz

  • Description modified (diff)

comment:7 Changed 4 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/libadblockplus/rev/a9228228ff02

comment:9 Changed 4 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.