Opened on 05/27/2015 at 02:47:02 PM

Closed on 07/29/2016 at 11:06:53 AM

Last modified on 07/29/2016 at 11:08:41 AM

#2597 closed change (fixed)

[Move core logic into adblockpluscore repository] Change adblockplus dependency to adblockpluscore in adblockpluschrome

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: fhd Blocked By: #2594
Blocking: #2593 Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


Once we have successfully moved the core logic from adblockplus to adblockpluscore #2594 we need to replace the adblockplus dependency with adblockpluscore in the adblockpluschrome repository.

What to change

Replace the adblockplus dependency with adblockpluscore in the adblockpluschrome repository and ensure the required core code is still included.

Update: The adblockplus repository was left behind because some strings from it are still being used, #4275 is a follow-up for completely removing it.

Attachments (0)

Change History (18)

comment:1 Changed on 05/27/2015 at 02:47:18 PM by kzar

  • Blocking 2593 added

comment:2 Changed on 05/27/2015 at 02:47:33 PM by kzar

  • Blocked By 2594 added

comment:3 Changed on 01/11/2016 at 01:42:43 PM by fhd

  • Component changed from Unknown to Platform
  • Tester set to Unknown

comment:4 Changed on 02/04/2016 at 11:56:18 AM by fhd

  • Owner set to kzar

Assigning to kzar, since he's actually looking into that.

comment:5 Changed on 02/04/2016 at 12:00:22 PM by fhd

  • Priority changed from Unknown to P2

comment:6 Changed on 02/04/2016 at 07:02:47 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 02/04/2016 at 07:02:47 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed on 07/29/2016 at 09:29:02 AM by kzar

  • Owner kzar deleted

comment:10 Changed on 07/29/2016 at 10:38:14 AM by fhd

kzar: Given how the push was apparently fixed by you five months ago, why not reassign yourself to this issue and then close it?

comment:11 Changed on 07/29/2016 at 10:53:10 AM by kzar

We still import some strings from adblockplus. We eventually intend to move them all over to adblockplusui / their rightful place but until then we're keeping adblockplus as a dependency. I can't remember all the details, only that it was non-trivial to move them all.

(I unassigned myself from the issue since I'm not working on this right now and it's not a priority.)

comment:12 Changed on 07/29/2016 at 10:57:00 AM by fhd

Fair enough, thanks for clarifying!

I suppose it's easier to understand if we separate the complete removal of the adblockplus dependency into a follow-up issue, I'll do that.

comment:13 Changed on 07/29/2016 at 11:04:37 AM by kzar

Sounds good to me:)

adblockpluschrome/metadata.common has all the locale imports under the [import_locales] section. Here are the relevant lines:

adblockplus/chrome/locale/*/ = subscription_invalid_location
adblockplus/chrome/locale/*/overlay.dtd = hideplaceholders.label
adblockplus/chrome/locale/*/filters.dtd = subscription.lastDownload.inProgress
adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label
adblockplus/chrome/locale/*/ = =name

comment:14 Changed on 07/29/2016 at 11:05:32 AM by fhd

  • Description modified (diff)

There we go: #4275.

comment:15 Changed on 07/29/2016 at 11:05:54 AM by fhd

Hehe, now we posted at almost the same time :) Would you mind adding that to #4275?

Last edited on 07/29/2016 at 11:06:09 AM by fhd

comment:16 Changed on 07/29/2016 at 11:06:45 AM by fhd

  • Owner set to kzar

Reassigning, since you were the one who actually did this.

comment:17 Changed on 07/29/2016 at 11:06:53 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:18 Changed on 07/29/2016 at 11:08:41 AM by fhd

  • Milestone set to Adblock-Plus-1.11-for-Chrome-Opera-Safari

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.