Opened 2 years ago

Closed 6 weeks ago

Last modified 8 days ago

#2606 closed defect (fixed)

Firefox logo shown in background on empty Adblock Browser New Tab and Search pages

Reported by: greiner Assignee: diegocarloslima
Priority: Unknown Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29341383/
https://codereview.adblockplus.org/29479633/

Description

Environment

Adblock Browser 1.0.0.20150522163354
Settings under Customize / Home / Panels:

  • Recent Tabs: hidden
  • History: hidden
  • Top Sites: hidden
  • Bookmarks: hidden
  • Reading List: hidden

How to reproduce

  1. Apply the settings as listed above
  2. Open a new tab

Observed behavior

Firefox logo shown in background (see screenshot)

Expected behavior

Adblock Browser logo shown in background

Attachments (2)

abb-newtab.png (34.1 KB) - added by greiner 2 years ago.
abb-search-background.png (78.2 KB) - added by Ross 2 years ago.

Download all attachments as: .zip

Change History (18)

Changed 2 years ago by greiner

comment:1 Changed 2 years ago by philll

  • Platform changed from Unknown to Adblock Browser for Android

See #2673

comment:2 Changed 2 years ago by Ross

  • Tester set to Ross

The Firefox logo is also visible if you:

  • Put the Adblock Browser search widget on the home screen.
  • Tap/focus the widget to start a search.
  • If you have no searches yet/they are cleared, a Firefox logo is visible (attached).

Changed 2 years ago by Ross

comment:3 Changed 2 years ago by Ross

  • Summary changed from Firefox logo shown in background on empty Adblock Browser New Tab page to Firefox logo shown in background on empty Adblock Browser New Tab and Search pages

comment:4 Changed 17 months ago by diegocarloslima

  • Owner set to diegocarloslima

comment:5 Changed 17 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 12 months ago by diegocarloslima

  • Ready set

comment:8 Changed 10 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 3 months ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Ross to Scheer

The Firefox Logo is correctly removed from the following screens:

Recent Tabs: hidden
History: hidden
Top Sites: hidden
Bookmarks: hidden
Reading List: hidden

The Firefox Logo is still present with the following screen:

  1. Put the Adblock Browser search widget on the home screen.
  2. Tap/focus the widget to start a search.
  3. If you have no searches yet/they are cleared, a Firefox logo is visible (attached).

ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

comment:10 Changed 3 months ago by greiner

As a sidenote I'd also like to point out that a full-color logo is used whereas the Firefox one was monochromatic which means that it draws more attention to it and appears more like it can be interacted with than the Firefox one.

comment:11 Changed 3 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:13 Changed 6 weeks ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 6 weeks ago by rscott

  • Tester changed from Scheer to Unknown
  • Verified working set

LGTM

comment:16 Changed 8 days ago by abpbot

A commit referencing this issue has landed:
Issue 2606 - Merge fix

Note: See TracTickets for help on using tickets.