Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2639 closed change (fixed)

Update adblockplus dependency to 816bc28239cd

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by sebastian)

Background

Beside some translations, following are the only changes imported by this update, visible in the builds:

#2192
Add notification opt-out mechanism
#2503
Inconsistent behavior: $document flag implied for exception rules with protocol included
#2582
ElemHide.getSelectorsForDomain() cannot be optimized by V8


What to change

A dependency update is sufficient.

Hints for testers

This update touches following areas of Adblock Plus:

Filter parsing

@@http://example.com shouldn't disable ABP (as indicated by the icon) on http://example.com anymore, but whitelist every request with an URL starting with http://example.com.

Notification mechanism

The changes here shouldn't be user-visible. But make sure that the notification mechanism works still as it did before. See 2505#Whattotest for instructions to test the mechanism.

Element hiding

The changes here shouldn't be user-visible beside slightly improving performance. But make sure that element hiding filters still work as they did before.

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:2 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 4 years ago by sebastian

For reference, this dependency update introduced two bugs related to notifications: #2640, #2641

Note: See TracTickets for help on using tickets.