Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2649 closed change (fixed)

Update buildtools dependency to bdd544d595f2

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by sebastian)

Background

Most importantly, jshydra were updated in buildtools to support ES6 generator syntax, which is now used in the core code imported from the adblockplus repository:

#2250
Update jshydra dependency to 8c4ee25543eb


Moreover, JsDoc has been updated, and documentation for the platform code were enabled:

#2231
Update to JsDoc 3.3.0
#2254
"build.py docs --quiet" generates warnings
#2271
Enable documentation for Chrome extensions


There are also some improvements to ensure_dependencies.py:

#2310
ensure_dependencies.py should allow both formats of Git SSH URLs
#2311
ensure_dependencies.py should fetch and track remote Git branches when required
#2443
ensure_dependencies.py should honour SKIP_DEPENDENCY_UPDATES env variable


What to change

A dependency update is sufficient.

Hints for testers

Those changes shouldn't be visible in the builds.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 5 years ago by sebastian

  • Milestone changed from Adblock-Browser-for-Android-next to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.