Opened 4 years ago

Closed 4 years ago

#2656 closed defect (fixed)

Regression: Notification not shown in icon popup

Reported by: greiner Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5000038044401664

Description

Environment

Chrome
Adblock Plus 1.8.12.1440

Background

#2642 moved the notification code into a separate module and thereby also removed the activeNotification variable from the background page's global namespace which notification.js accesses in popup.html to determine whether the notification box should be displayed in the icon popup.

What to change

Expose the data of the currently active notification to the icon popup again.

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Owner set to sebastian
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)

comment:4 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.