Opened 5 years ago

Closed 4 years ago

#2668 closed change (fixed)

Use new subscription types in new options page

Reported by: saroyanm Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: fhd, greiner Blocked By: #2822
Blocking: #2802, #2821 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328672/

Description (last modified by greiner)

Background

In #2822 we will add new subscription types to sitescripts. This allows us to distinguish between certain types of subscriptions which we can use to map them to specific features that we want to expose in the new options page.

What to change

  • Remove the "popular" attribute from subscriptions.xml that was introduced in #1526
  • Add "type" attribute to subscriptions.xml and update it according to #2825
  • Remove the "isAdsType" and "isPopular" properties and instead check for the subscription type
  • Add texts for the feature names (preferably texts should not be duplicated in firstRun.json and options.json)
    • anti-adblock: Hide Adblock Warning Messages
    • malware: Block Malware
    • privacy: Disable Tracking
    • social: Remove Social Media Buttons
  • Account for future additions of a short description (used in "Blocking lists" section) and a long description (used in subscription tooltip for the "More blocking options" section)
  • Instead of using the value of the "specialization" attribute from subscriptions.xml as the feature title, use the newly added texts

Notes for dependency update

This change introduces strings that are shared between first-run page and options page. Therefore common.json needs to be imported to avoid a 404 error in the console when retrieving the translations.

Change History (12)

comment:1 Changed 5 years ago by saroyanm

  • Cc greiner added

Please note that the description is vague intentionally, we should fix it in near future, but this will help us to keep tracking on that existing issue.
So definitely not ready yet.

comment:2 Changed 5 years ago by greiner

  • Priority changed from Unknown to P2

comment:3 Changed 4 years ago by saroyanm

  • Blocking 2706 added; 1524 removed

comment:4 Changed 4 years ago by greiner

  • Description modified (diff)
  • Tester set to Unknown

comment:5 Changed 4 years ago by greiner

  • Blocking 2802 added

comment:6 Changed 4 years ago by greiner

  • Blocked By 2822 added
  • Blocking 2821 added; 2706 removed
  • Description modified (diff)
  • Summary changed from Localize recommended subscriptions [adblockplusui] to Use new subscription types in new options page

comment:7 Changed 4 years ago by greiner

  • Description modified (diff)

comment:8 Changed 4 years ago by greiner

  • Ready set

comment:9 Changed 4 years ago by greiner

  • Owner set to greiner

comment:10 Changed 4 years ago by greiner

  • Description modified (diff)

comment:11 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:12 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.