Opened 4 years ago

Last modified 4 years ago

#2668 closed change

Localize recommended subscriptions [adblockplusui] — at Version 4

Reported by: saroyanm Assignee:
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: fhd, greiner Blocked By:
Blocking: #2706 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328672/

Description (last modified by greiner)

Background

with #1526 we have new version of subscriptions.xml which also contains recommended/popular subscriptions, currently we are using specialization attribute value of that "popular" subscriptions to show their title in the new options UI, which doesn't allow us currently translate them.

What to change

Replace the "popular" attribute in subscriptions.xml, which has been added in #1526, with an attribute "id". This attribute is supposed to contain a unique ID for a subscription (separate from its URL) that we can associate with translations.

The translations should be in a separate JSON file and contain:

  • Name (used in "More blocking options" section in General tab of new options page)
  • Short description (used in "Blocking lists" section in Advanced tab of new options page)
  • Full description (used in subscription tooltip for the "More blocking options" section in General tab of new options page)

Change History (4)

comment:1 Changed 4 years ago by saroyanm

  • Cc greiner added

Please note that the description is vague intentionally, we should fix it in near future, but this will help us to keep tracking on that existing issue.
So definitely not ready yet.

comment:2 Changed 4 years ago by greiner

  • Priority changed from Unknown to P2

comment:3 Changed 4 years ago by saroyanm

  • Blocking 2706 added; 1524 removed

comment:4 Changed 4 years ago by greiner

  • Description modified (diff)
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.