Opened 4 years ago

Closed 4 years ago

#2669 closed change (fixed)

Wrap header, footer and nav content with corresponding tags

Reported by: saroyanm Assignee: greiner
Priority: P4 Milestone:
Module: User-Interface Keywords:
Cc: fhd, greiner Blocked By: #1524
Blocking: #2407 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322998/

Description (last modified by saroyanm)

Background

With #1524 we are going to redesign Adblock Plus options page.
With #1526 we have implemented skeleton and initial logic, but we don't wrap any content with HTML5 header, footer and nav tags

What to change

Wrap the corresponding content of the new option page with the header, footer and nav tags:

  • change the top left div in sidebar with the id "page-title" to header tag.
  • wrap with <nav> tag main navigation elements (id="main-navigation-tabs") that contains General, Advanced and Help tab navigation.
  • wrap with <footer> tag the navigation on the bottom of sidebar ("Share" and "Donate").

Change History (8)

comment:1 follow-up: Changed 4 years ago by greiner

  • Blocking 2407 added
  • Priority changed from Unknown to P4

Could you be a bit more specific about which elements should be put into (or turned into) which HTML5 element? It's not obvious from the current description.

comment:2 Changed 4 years ago by greiner

  • Cc greiner added

comment:3 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:4 in reply to: ↑ 1 Changed 4 years ago by saroyanm

Replying to greiner:

Could you be a bit more specific about which elements should be put into (or turned into) which HTML5 element? It's not obvious from the current description.

Done

comment:5 Changed 4 years ago by greiner

  • Ready set

comment:6 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:7 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.