Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2677 closed change (fixed)

Don't bundle subscriptions.xml

Reported by: fhd Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #2706 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322993/

Description (last modified by greiner)

Background

We're currently bundling the subscriptions.xml file in the adblockplusui repository, mainly because we're not yet sure if and how we need to change its format to have all the relevant meta data about recommended subscriptions.

What to change

We shouldn't bundle subscriptions.xml in the adblockplusui repository - the host repository is already bundling it, we can access it from there. We still need a dummy file for the test environment, however.

We should mention this requirement in the README.

Change History (10)

comment:1 Changed 4 years ago by saroyanm

  • Blocking 2706 added

comment:2 Changed 4 years ago by greiner

  • Cc greiner added
  • Description modified (diff)
  • Type changed from defect to change

comment:3 follow-up: Changed 4 years ago by fhd

This was filed as a defect deliberately. Discussed it with Philip beforehand: If we don't know _what_ to do about it, just that there's a problem, it should be a defect, not a change.

comment:4 in reply to: ↑ 3 Changed 4 years ago by greiner

Replying to fhd:

This was filed as a defect deliberately. Discussed it with Philip beforehand: If we don't know _what_ to do about it, just that there's a problem, it should be a defect, not a change.

Sounds reasonable but I don't think it applies here because the "what to change" section and even the title mention what to do about it. Note that the ticket description doesn't describe a problem which is why I also changed the description headlines.

comment:5 Changed 4 years ago by fhd

I initially suspected that we also have to do something with subscriptions2.xml here, but I've looked into that today and the only thing we're interested in is really subscriptions.xml, fetched from the host application, as the description says. So yeah, I agree, makes more sense as a change.

comment:6 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:7 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 4 years ago by matze

  • Blocking 3966 added

comment:10 Changed 4 years ago by matze

  • Blocking 3966 removed
Note: See TracTickets for help on using tickets.