Opened 6 years ago

Closed 22 months ago

Last modified 22 months ago

#268 closed change (fixed)

Remove cssfx.js and empty.css hack from adblockplus.org

Reported by: fhd Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wspee Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29670669/

Description (last modified by juliandoucette)

Background

empty.css is a hack that made things work in IE8 in the past.

What to change

This hack is no longer necessary because we have removed all uses of features that this "hack" enabled.

Change History (14)

comment:1 Changed 5 years ago by saroyanm

  • Component changed from Infrastructure to Websites
  • Platform set to Unknown

comment:2 Changed 3 years ago by juliandoucette

  • Keywords goodfirstbug added
  • Tester set to Unknown

comment:3 Changed 2 years ago by juliandoucette

  • Priority changed from P4 to P5

Reprioritizing because of ABP.org redesign.

comment:4 Changed 2 years ago by juliandoucette

  • Sensitive unset

comment:5 Changed 2 years ago by juliandoucette

Note: I think that [cssFx is the wrong approach in the first place, this hack is no longer needed to meet our browser requirements].

comment:6 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 2 years ago by juliandoucette

  • Cc ire wspee added
  • Milestone set to adblockplus.org 2.1 index page
  • Priority changed from P5 to P3
  • Review URL(s) modified (diff)
  • Status changed from reviewing to reopened

comment:8 Changed 22 months ago by juliandoucette

  • Owner set to juliandoucette

comment:9 Changed 22 months ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:10 Changed 22 months ago by juliandoucette

  • Description modified (diff)

comment:11 Changed 22 months ago by juliandoucette

  • Summary changed from [adblockplus.org] Try to defer cssfx.js to avoid the empty.css IE8 hack to Remove cssfx.js and empty.css hack from adblockplus.org

comment:12 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 268 - Removed cssfx and empty.css dependency

comment:13 Changed 22 months ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 22 months ago by juliandoucette

  • Milestone adblockplus.org 2.1 index page deleted

Milestone adblockplus.org 2.1 index page deleted

Note: See TracTickets for help on using tickets.