Opened 2 years ago

Last modified 2 years ago

#2683 reviewing defect

Rietveld mails include reply@codereview-hr.appspotmail.com in various headers

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: fhd, trev, fred Blocked By: #2704
Blocking: #2182 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29318010
https://codereview.adblockplus.org/29317154

Description

INFO     2015-06-15 08:46:55,517 mail_stub.py:143] MailService.Send
  From: sebastian@adblockplus.org
  To: d...@adblockplus.org
  To: m...@adblockplus.org
  Cc: t...@adblockplus.org
  Cc: reply@codereview-hr.appspotmail.com
  Reply-to: s...@adblockplus.org, d...@adblockplus.org, m...@adblockplus.org, t...@adblockplus.org, reply@codereview-hr.appspotmail.com
  Subject: Issue 2681 - Fixed: Thunderbird 31 is listed twice on requirements page (issue 29317012 by s...@adblockplus.org)
  Body:
    Content-type: text/plain
    Data length: 813
INFO     2015-06-15 08:46:56,371 xmpp_service_stub.py:110] Sending an XMPP Message:
    From:
       codereview-hr@appspot.com/bot
    Body:
       Comments published by Sebastian Noack: Issue 2681 - Fixed: Thunderbird 31 is listed twice on requirements page
https://codereview.adblockplus.org/29317012/
    Type:
       chat
    Raw Xml:
       0
    To JIDs:
       d...@adblockplus.org

Whatever this is meant for, it is surely not wanted in our current setup.

Change History (8)

comment:1 Changed 2 years ago by matze

  • Owner set to matze

comment:2 Changed 2 years ago by matze

  • Cc fhd trev fred added
  • Ready set

comment:3 Changed 2 years ago by matze

  • Component changed from Unknown to Infrastructure
  • Priority changed from Unknown to P2

comment:4 Changed 2 years ago by matze

  • Blocked By 2704 added

comment:5 Changed 2 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by matze

  • Blocking 2703 added

comment:7 Changed 2 years ago by trev

As noted in the review, we shouldn't fork Rietveld for this - we can override properties of the settings module from the app engine's sandbox. Something like this will work:

  from google.appengine.tools.devappserver2.python.sandbox import
_MODULE_OVERRIDE_POLICIES, ModuleOverridePolicy
  _MODULE_OVERRIDE_POLICIES['settings'] = ModuleOverridePolicy(
      overrides={'RIETVELD_INCOMING_MAIL_ADDRESS': None},
      default_pass_through=True
  )

comment:8 Changed 2 years ago by matze

  • Blocking 2703 removed
Note: See TracTickets for help on using tickets.