Opened 6 years ago

Last modified 2 years ago

#268 closed change

[adblockplus.org] Try to defer cssfx.js to avoid the empty.css IE8 hack — at Version 6

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wspee Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29670669/

Description

Background

empty.css is a hack to make things work in IE8.

What to change

Instead of using this hack, we should try to defer the loading of cssfx.js.

Change History (6)

comment:1 Changed 6 years ago by saroyanm

  • Component changed from Infrastructure to Websites
  • Platform set to Unknown

comment:2 Changed 4 years ago by juliandoucette

  • Keywords goodfirstbug added
  • Tester set to Unknown

comment:3 Changed 3 years ago by juliandoucette

  • Priority changed from P4 to P5

Reprioritizing because of ABP.org redesign.

comment:4 Changed 3 years ago by juliandoucette

  • Sensitive unset

comment:5 Changed 3 years ago by juliandoucette

Note: I think that [cssFx is the wrong approach in the first place, this hack is no longer needed to meet our browser requirements].

comment:6 Changed 3 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.