Opened 4 years ago

Closed 3 years ago

#2694 closed defect (fixed)

Wrong order of parameters `source, target` in logging message

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://github.com/adblockplus/buildtools/pull/6

Description

Environment

git commit: efa6615083333908f938dfe03fee37ce030ae9f5
https://github.com/adblockplus/buildtools/blob/efa6615083333908f938dfe03fee37ce030ae9f5/ensure_dependencies.py#L307

How to reproduce

  1. Call it when the script needs to be updated

Observed behaviour

INFO: Updating .\adblockplus\buildtools\ensure_dependencies.py from ./ensure_dependencies.py, don't forget to commit

Expected behaviour

INFO: Updating ./ensure_dependencies.py from .\adblockplus\buildtools\ensure_dependencies.py, don't forget to commit

What to change

Swap source and target to make them conform with the textual description.

Change History (8)

comment:1 Changed 4 years ago by sebastian

  • Cc kzar added
  • Keywords goodfirstbug added
  • Priority changed from Unknown to P4
  • Ready set

comment:2 follow-up: Changed 4 years ago by kzar

@sergz Any reason why the link is for my commit efa6615083333908f938dfe03fee37ce030ae9f5 instead of either HEAD or Wladimir's commit c3fcb9d9d937ff1cf79520a641a7967a5339197d?

comment:3 Changed 4 years ago by sebastian

I think he were merely referring to the code line, and didn't bother the particular commit.

Anyway, I put you in CC in case you feel like fixing this. Otherwise, I leave it as goodfirstbug for new contributors, or whoever is going to get annoyed enough by this to fix it. ;)

comment:4 Changed 4 years ago by kzar

Arg sorry, the irrelevant commit hash linked is for Sebastian's commit not mine. I was confused by GitHub's interface, it showed my name and details of a commit at the top, which was the latest commit for the file in question. Confusing! Either way I see what you both mean, and I agree it's a goodfirstbug.

comment:5 in reply to: ↑ 2 Changed 4 years ago by sergz

Replying to kzar:

@sergz Any reason why the link is for my commit efa6615083333908f938dfe03fee37ce030ae9f5 instead of either HEAD or Wladimir's commit c3fcb9d9d937ff1cf79520a641a7967a5339197d?

Replying to sebastian:

I think he were merely referring to the code line, and didn't bother the particular commit.

Yes, it's merely a reference to the code line at the concrete state.

comment:6 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Tester set to Unknown

comment:7 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/buildtools/rev/c519bc096667

comment:8 Changed 3 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.