Opened 4 years ago

Last modified 4 years ago

#2705 new defect

Improve notification generation error reporting

Reported by: Ross Assignee:
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



ABP / Windows 8.1 x64

How to reproduce

  1. Create the notification Invalid1 (below) on the server.
  2. Commit the new notification, observe no errors are logged.
  3. Visit <ServerAddress>/notification.json
  4. Observe the newly committed notification is not included.

Test data

Invalid1 (target is wrong format):

severity = information
target = adblockplus
title.en-US = Other info
message.en-US = This is some other info

Observed behaviour

When notification generation fails because of a bad notification file, the errors/problems are not displayed/logged making the problem difficult to debug.

Expected behaviour

Problems with notification files to be displayed or logged.

Change History (2)

comment:1 Changed 4 years ago by Ross

Problems that should/could be logged:

  • Required keys that are missing.
  • Required keys (title, message etc.) that are blank.
  • Target key not matching any known targets.
  • End date set before start date.

comment:2 Changed 4 years ago by fhd

  • Blocking 2162 removed
  • Component changed from Unknown to Sitescripts
  • Priority changed from Unknown to P3
  • Ready set
Note: See TracTickets for help on using tickets.