Opened 5 years ago

Last modified 13 months ago

#2705 new defect

Improve notification generation error reporting

Reported by: Ross Assignee:
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



ABP / Windows 8.1 x64

How to reproduce

  1. Create the notification Invalid1 (below) on the server.
  2. Commit the new notification, observe no errors are logged.
  3. Visit <ServerAddress>/notification.json
  4. Observe the newly committed notification is not included.

Test data

Invalid1 (target is wrong format):

severity = information
target = adblockplus
title.en-US = Other info
message.en-US = This is some other info

Observed behaviour

When notification generation fails because of a bad notification file, the errors/problems are not displayed/logged making the problem difficult to debug.

Expected behaviour

Problems with notification files to be displayed or logged.

Change History (3)

comment:1 Changed 5 years ago by Ross

Problems that should/could be logged:

  • Required keys that are missing.
  • Required keys (title, message etc.) that are blank.
  • Target key not matching any known targets.
  • End date set before start date.

comment:2 Changed 5 years ago by fhd

  • Blocking 2162 removed
  • Component changed from Unknown to Sitescripts
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 13 months ago by kvas

Dear stakeholders of this ticket,

I'm cleaning up Sitescripts tickets in Trac due to its phase out. This is one of the tickets that I could not myself close or move, so I need your input on it.

Please let me know if this ticket is still relevant for you and we can then discuss where it should be moved. If you think that this ticket is no longer relevant, you can write a comment explaining this or just ignore this message.

If I see now comments in the ticket on October 14, I will close it as rejected.

Best regards,

Note: See TracTickets for help on using tickets.