Opened 4 years ago

Closed 3 years ago

Last modified 2 years ago

#2709 closed change (fixed)

Remove legacy failsafe code form Utils.getString

Reported by: sebastian Assignee: wspee
Priority: P4 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29366863/

Description

Background

The function Utils.getString() returns the translation for strings imported from Adblock Plus for Firefox. Therefore it relies on ext.i18n.getMessage, and simply returns the message id, if ext.i18n isn't available. However, ext.i18n is always available (now), and this check is obsolete.

What to change

Remove the check for ext.i18n from Utils.getString in lib/utils.js.

Change History (6)

comment:1 Changed 3 years ago by wspee

  • Owner set to wspee
  • Tester set to Unknown

comment:2 Changed 3 years ago by wspee

  • Status changed from new to reviewing

comment:3 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)

comment:4 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 2709 - Removed legacy failsafe code form Utils.getString

comment:5 Changed 3 years ago by wspee

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Hasn't caused any obvious regressions.

ABP 1.12.4.1739
Chrome 49 / 56 / Windows 10
Chrome 56 / OS X 10.12
Chrome 56 / Ubuntu 16.04
Opera 37 / 41 / Windows 7
Safari 10 / OS X 10.12

Note: See TracTickets for help on using tickets.