Opened 5 years ago

Last modified 3 years ago

#2709 closed change

Remove legacy failsafe code form Utils.getString — at Version 3

Reported by: sebastian Assignee: wspee
Priority: P4 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



The function Utils.getString() returns the translation for strings imported from Adblock Plus for Firefox. Therefore it relies on ext.i18n.getMessage, and simply returns the message id, if ext.i18n isn't available. However, ext.i18n is always available (now), and this check is obsolete.

What to change

Remove the check for ext.i18n from Utils.getString in lib/utils.js.

Change History (3)

comment:1 Changed 4 years ago by wspee

  • Owner set to wspee
  • Tester set to Unknown

comment:2 Changed 4 years ago by wspee

  • Status changed from new to reviewing

comment:3 Changed 4 years ago by wspee

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.