Opened 6 years ago

Closed 7 weeks ago

Last modified 9 days ago

#271 closed change (rejected)

Do not attemp downloading filters if there is no internet connection

Reported by: trev Assignee:
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: erikvold Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Currently the browser will try downloading filters regardless of whether there is an internet connection. It will fail and only try downloading again after a day.

What to change

We shouldn't try downloading if navigator.onLine is false, see https://developer.mozilla.org/en-US/docs/Web/API/NavigatorOnLine.onLine

Change History (5)

comment:1 Changed 6 years ago by trev

Note that in Firefox we don't have access to a window so we would need to use nsIIOService.offline instead (https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIIOService#Attributes).

comment:2 Changed 5 years ago by philll

  • Ready set

comment:3 Changed 13 months ago by erikvold

  • Cc erikvold added
  • Platform set to Unknown / Cross platform
  • Tester set to Unknown

comment:4 Changed 2 months ago by noushadamir

spam

Last edited 9 days ago by kzar (previous) (diff)

comment:5 Changed 7 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.