Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2720 closed change (fixed)

[Adblocking settings] Add the other filter lists category

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015081632
Module: Adblock-Browser-for-Android Keywords: 2015q3
Cc: Blocked By:
Blocking: #2345 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322610/

Description (last modified by fhd)

Background

See #2345.

What to change

Add a new settings category, titled Other filter lists, where the user can manage additional filter lists.

As the mockup shows, there are some filter lists the user can turn on and off, and there is a menu item for adding a custom filter list.

Filter list items

There should be an item for each filter list, and a toggle button for turning it on and off.

The ? icon shown in the mockup for each filter list item should be left out in the first version.

The toggle button should not enable/disable the filter list, but rather add or remove it internally. Consequently, when a filter list is turned off, its item should disappear - unless it was one of the predefined filter lists.

Predefined filter lists

Since we're not sure yet if we want to show all known filter lists as predefined lists here, we should hard code the following for now:

Adding filter lists

Below the filter list items, there should be an item labeled Add other filter list that brings up a new dialog.

There is a mockup for this dialog as well. It should have a text field labeled URL and a button labeled Add filter list from this URL.

The button should be disabled until a valid URL has been entered.

After adding a new list, it should be added internally, and it should show up as a filter list item on the previous activity.

Attachments (4)

adblock browser v12 - 4-2 further blocking.png (79.5 KB) - added by fhd 4 years ago.
adblock browser v12 - 4-2-1 add other blocking list.png (187.5 KB) - added by fhd 4 years ago.
abb_add_other_blocking_list_1.png (30.9 KB) - added by rjeschke 4 years ago.
Implemented version of 'Add other blocking list', intial
abb_add_other_blocking_list_2.png (43.9 KB) - added by rjeschke 4 years ago.
Implemented version of 'Add other blocking list', valid URL entered

Download all attachments as: .zip

Change History (19)

comment:1 Changed 4 years ago by fhd

  • Description modified (diff)
  • Platform changed from Unknown to Android
  • Ready unset

comment:2 Changed 4 years ago by fhd

  • Description modified (diff)

comment:3 Changed 4 years ago by fhd

  • Summary changed from [Adblocking settings] Other filter lists to [Adblocking settings] Add the other filter lists category

comment:4 Changed 4 years ago by fhd

  • Owner set to rjeschke
  • Ready set

Assigning to you René, since I know you're working on it :P

comment:5 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

comment:6 Changed 4 years ago by fhd

  • Description modified (diff)
  • Tester set to Unknown

comment:7 follow-up: Changed 4 years ago by annlee@…

There are errors in the text in the mockup - i.e. 'Further blocking options' should be 'More blocking options', and 'Disable Malware Websites' should be 'Disable Malware Domains'

Here is the complete set of text to be used instead:

More blocking options

Disable Tracking
Disable Malware Domains
Disable Anti-Adblocking Messages
Disable Social Media Buttons

comment:8 in reply to: ↑ 7 Changed 4 years ago by philll

Replying to annlee@…: "Disable" sounds like it was a feature offered for those things, while it's actually us blocking those resources.

There are errors in the text in the mockup - i.e. 'Further blocking options' should be 'More blocking options', and 'Disable Malware Websites' should be 'Disable Malware Domains'

Here is the complete set of text to be used instead:

More blocking options

Disable Tracking
Disable Malware Domains
Disable Anti-Adblocking Messages
Disable Social Media Buttons

comment:9 Changed 4 years ago by rjeschke

I will move away from the mockups for URL input, here are the reasons:

  1. Having a PreferenceScreen that is only used for entering text, and which then magically goes back one screen is wrongly designed (IMHO)
  2. EditText and Button are not supported on PreferenceScreens on Android
  3. Injecting those elements through layout XML files result in undefined behaviour and UI elements no longer updated
  4. The screen in the mockup behaves like a Dialog without showing this to the user (i.e. no cancel button present)
  5. We do not have the manpower (neither development nor testing wise) to implement a custom element that works correctly on all Fennec supported API platforms, and still looks/feels like Fennec UI
  6. Magically closing a nested PreferenceScreen is also not supported on Android, though there are ways to exploit some internal mechanisms (that might change in the future) to hack this functionality
  7. We are tied to using Fennec's GeckoPreferences, as this is the common entry point for all preferences, so we can not use fully custom UI here (see item 5)

The appropriate solution for this task is: use a Dialog.

So we will have a popup Dialog titled Add other blocking list, that has the appropriate input filed/description, URL validation with error display, and two buttons: Add and Cancel. The Add button will be disabled until a valid URL is entered.

Version 0, edited 4 years ago by rjeschke (next)

Changed 4 years ago by rjeschke

Implemented version of 'Add other blocking list', intial

Changed 4 years ago by rjeschke

Implemented version of 'Add other blocking list', valid URL entered

comment:10 Changed 4 years ago by rjeschke

Added screenshots of the implemented version.

comment:11 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:12 Changed 4 years ago by Compuitguy

Asked this before on bug #2345 with no answer

Are these changes gonna make its way to Adblock Plus for Firefox Mobile ?

comment:13 Changed 4 years ago by fhd

  • Keywords 2015q3 added

comment:14 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next
Note: See TracTickets for help on using tickets.