Opened 4 years ago

Last modified 4 years ago

#2720 closed change

[Adblocking settings] Add the other filter lists category — at Version 6

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015081632
Module: Adblock-Browser-for-Android Keywords: 2015q3
Cc: Blocked By:
Blocking: #2345 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322610/

Description (last modified by fhd)

Background

See #2345.

What to change

Add a new settings category, titled Other filter lists, where the user can manage additional filter lists.

As the mockup shows, there are some filter lists the user can turn on and off, and there is a menu item for adding a custom filter list.

Filter list items

There should be an item for each filter list, and a toggle button for turning it on and off.

The ? icon shown in the mockup for each filter list item should be left out in the first version.

The toggle button should not enable/disable the filter list, but rather add or remove it internally. Consequently, when a filter list is turned off, its item should disappear - unless it was one of the predefined filter lists.

Predefined filter lists

Since we're not sure yet if we want to show all known filter lists as predefined lists here, we should hard code the following for now:

Adding filter lists

Below the filter list items, there should be an item labeled Add other filter list that brings up a new dialog.

There is a mockup for this dialog as well. It should have a text field labeled URL and a button labeled Add filter list from this URL.

The button should be disabled until a valid URL has been entered.

After adding a new list, it should be added internally, and it should show up as a filter list item on the previous activity.

Change History (8)

comment:1 Changed 4 years ago by fhd

  • Description modified (diff)
  • Platform changed from Unknown to Android
  • Ready unset

comment:2 Changed 4 years ago by fhd

  • Description modified (diff)

comment:3 Changed 4 years ago by fhd

  • Summary changed from [Adblocking settings] Other filter lists to [Adblocking settings] Add the other filter lists category

comment:4 Changed 4 years ago by fhd

  • Owner set to rjeschke
  • Ready set

Assigning to you René, since I know you're working on it :P

comment:5 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

comment:6 Changed 4 years ago by fhd

  • Description modified (diff)
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.