Opened 5 years ago

Closed 5 years ago

#2722 closed change (fixed)

Don't report persistent errors with external APIs more often than once a day

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: trev, fhd Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29321081

Description

Background

We rely on browser vendor's update APIs to retrieve the current browser versions to be listed on https://adblockplus.org/en/requirements. But occasionally these requests fail.

We already implemented logic to fallback to the last successfully retrieved list of browser versions then. And we also don't log warnings for failures that occur for less than two hours in a row, anymore. But persistent issues, we usually cannot do anything about, still spam the cron log every 15 minutes.

What to change

Don't log warnings for persistent failures more often than once a day.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.