Opened 4 years ago

Closed 4 years ago

#2723 closed change (fixed)

Raise a more detailed exception when there is no update for Mozilla products

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29321106

Description (last modified by sebastian)

Background

We rely on browser vendor's update APIs to retrieve the current browser versions to be listed on ​https://adblockplus.org/en/requirements.

Recently, requests failed because the beta channel for Firefox is empty. However, the exception raised there is a generic IndexError and doesn't give any information about what's causing it.

What to change

If the <updates> node in the XML retrieved from a Mozilla update URL like this is empty, raise an exception indicating the reason as well as the product and channel.

Change History (3)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.