Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2726 closed change (fixed)

Reuse texts from Firefox version for Platform notification opt-out

Reported by: greiner Assignee: greiner
Priority: P3 Milestone: Adblock-Plus-1.9.3-for-Chrome-Opera-Safari-next
Module: Platform Keywords:
Cc: Blocked By: #2193, #2195
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322881/

Description

Background

In #2195 we added a global notification opt-out to Chrome/Opera/Safari but couldn't reuse the texts from the Firefox version yet due to #2193 not being done. Therefore the adblockpluschrome repository contains duplicate texts which need to replaced with the ones from the Firefox version.

What to change

  • Remove these strings from _locales/en_US/messages.json
    • overlay_notification_closing_button_hide
    • overlay_notification_closing_button_optout
    • overlay_shownotifications_label
  • Import these strings from the adblockplus repository's overlay.dtd by adding them to metadata.common
    • notification.closing.button.hide
    • notification.closing.button.optout
    • shownotifications.label

Change History (5)

comment:1 Changed 4 years ago by greiner

  • Component changed from User-Interface to Platform

comment:2 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:3 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.