Opened 4 years ago

Closed 3 weeks ago

#2727 closed change (rejected)

Add return value to Notification.toggleIgnoreCategory()

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

In #2192 we implemented Notification.toggleIgnoreCategory(...) to start/stop ignoring notification categories. However, the UI still needs to find out itself what the resulting value is by doing Prefs.notifications_ignoredcategories.indexOf(...) != -1. This could be avoided by returning the result when using Notification.toggleIgnoreCategory.

What to change

  • Add boolean return value to Notification.toggleIgnoreCategory() which should be true if the passed category is being ignored after toggling or false otherwise.
  • Add unit tests to check return value
  • Make use of return value in adblockplus and adblockpluschrome

Change History (1)

comment:1 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.