Opened 4 years ago

Closed 4 years ago

#2747 closed change (fixed)

new Options Page: default state for whitelisted websites

Reported by: sven Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #2355 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329095/

Description (last modified by greiner)

Background

For the moment only the edit mode of the whitelisted websites option is implemented, but there is a default state for this method which was not specified before.

What to change

  • Implement ability to toggle state of "add website" UI element
    • default state
      • Clicking on "add website" should switch to edit state
    • edit state
      • Clicking on "+add", "+" or the Enter icon should add the entered domain (if any) and switch to the default state
      • Clicking on "cancel" should switch to default state
  • If there are no whitelisted websites add the box seen in the default state design

Attachments (3)

options_page_whitelistedwebsites-1.jpg (28.8 KB) - added by sven 4 years ago.
options_page_103-2.jpg (34.4 KB) - added by sven 4 years ago.
options_page_103-3.jpg (49.4 KB) - added by sven 4 years ago.

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by sven

Changed 4 years ago by sven

Changed 4 years ago by sven

comment:1 Changed 4 years ago by sven

  • Description modified (diff)

comment:2 Changed 4 years ago by greiner

  • Blocking 2355 added
  • Cc greiner added

Please extend this ticket to also include default states for other tables in the options page.

comment:3 Changed 4 years ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed 4 years ago by greiner

  • Owner set to greiner

comment:5 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.