Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2751 closed change (fixed)

[Support other languages] Automate multi-language builds

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015081632
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #2750
Blocking: #2749 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29323497/
https://codereview.adblockplus.org/29323490/
https://codereview.adblockplus.org/29323500/
https://codereview.adblockplus.org/29323547/
https://codereview.adblockplus.org/29323540/

Description (last modified by fhd)

Background

See #2749.

What to change

#2750 makes it possible to apply Firefox's translations - we need to use this mechanism from our build automation (currently build_release.py).

However, with the increased complexity, it makes more sense to move this to a dedicated repository that fetches both adblockbrowser and mozharness and performs the build.

Change History (8)

comment:1 Changed 4 years ago by fhd

  • Description modified (diff)
  • Summary changed from [Support other languages] Perform multi-language builds via build_release.py to [Support other languages] Automate multi-language builds

comment:2 Changed 4 years ago by fhd

  • Owner set to fhd

comment:3 Changed 4 years ago by fhd

Initial commit pushed to a new repository: https://bitbucket.org/adblockplus/adblockbrowser-build/commits/a584d5847080d60b5b543d68e5fb1c553178f9fe

Being the initial commit, I couldn't upload it for review. However, there's not that much in there: build.py is almost identical to build_release.py, the rest is created according to the instructions in adblockbrowser/README.md.

I'm still planning three things here:

  1. Add a basic README.
  2. Commit generic mozconfigs for devbuild and release builds that get the Android SDK/NDK paths from environment variables passed in through build.py.
  3. Remove build_release.py from adblockbrowser and mention adblockbrowser-build in the README.

comment:4 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)

Uploaded separate reviews for all three things.

comment:5 Changed 4 years ago by fhd

  • Status changed from new to reviewing

comment:6 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)

comment:8 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next
Note: See TracTickets for help on using tickets.